Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • X Xfiles
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 39
    • Issues 39
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 0
    • Merge requests 0
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • eXlibriseXlibris
  • Xfiles
  • Issues
  • #50
Closed
Open
Issue created May 28, 2019 by Alexis SALZMAN@asalzmanMaintainer

getAttachedSVLSHeavisideData/getAttachedVLSHeavisideData functions

Both functions are using dynamic_cast and it cost a lot (65% under callgrind, instead of seeing getData). Apparently it could be replaced by a static cast if we are confident with the used tag. Because type checking is only here to prevents miss usage of tag not used to attach HeavisideData ... From a design point of view creating a class that store tag and ways to access data related to this tag is safer. This is what xAttachedDataManagerAOMD provides and it may be used instead of those functions. But anyway getData return a void pointer wich is null if no data found and a static_cast may work as a charm in most cases (no one use those functions directly ... no ?? ). By removing getAttachedSVLSHeavisideData declaration in header it would finish to isolated this function ... and avoid her mis usage ...

Assignee
Assign to
Time tracking