Skip to content

ShortMatrix: rm Indices usage+nr/nc usage+NDEBUG+inline

Alexis SALZMAN requested to merge new_index into master

Do some enhancements in the ShortMatrixBase hierarchy:

  • Remove Indices usage as much as possible.
  • Use nr/nc in place of nRows/nCols when possible.
  • Force the use of integers in tests of loops, in place of calls to nCols/nRows.
  • Add NDEBUG usage to remove security checks when in "Release" mode (CMake sense). This implies that ctest runs in 'Release' mode may pass if indices are wrong, but doesn't hurt computational results! In "Debug" mode, ctest will do all tests, including index checking, and thus should be preferred for CI.
  • Transfer the access operator implementation into the header as an explicit inline method. The question remains of whether to separate the implementation from the declaration in the header or not.
  • For maintenance simplicity, remove the redundant implementation in the ShortSqrMatrix operators.
  • Use the prefix operator ++ instead of the postfix operator (for dumb compilers)
  • For the IndexMatrix () access operator, we enforce the direct use of indirection to avoid using the [] operator, which may eventually be deprecated in the future.

Merge request reports